Use pkg_installed() instead of is_installed() #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this was a cause of two parallel PRs, one of which fixed removed the function, but other reverted some of the uses back to the old call. Thanks for the PR! |
|
Thanks for the quick merge! For what it's worth, I was motivated to create this PR because commit f986e72 broke r-hub while I was using it to track down a bug on an OS I don't have regular access to. It was the second time a change in remotes had broken r-hub in ~10 days. I expected r-hub to be more stable than that, so I suggested a solution in r-hub/rhub#147. Anyway, I just wanted to explain the motivation, in case you weren't aware. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit f986e72 removed is_installed()
but did not replace all its calls with a suitable alternative.
See #147, #148.