Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set RGL_USE_NULL to avoid rgl install errors #333

Merged
merged 2 commits into from
Apr 8, 2019
Merged

Set RGL_USE_NULL to avoid rgl install errors #333

merged 2 commits into from
Apr 8, 2019

Conversation

jefferis
Copy link
Contributor

@jefferis jefferis commented Apr 7, 2019

@jefferis
Set RGL_USE_NULL to avoid rgl install errors
dc2665d 
* fixes an issue when installing packages depending on rgl in a headless environment
  (e.g. remote server such as travis)
* closes r-lib#332
gaborcsardi
gaborcsardi requested changes Apr 8, 2019
View reviewed changes
Copy link
Member

@gaborcsardi gaborcsardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you pls change it to a string, and also add a bullet point to the NEWS file? Thanks!

R/install.R Outdated Show resolved Hide resolved
@gaborcsardi gaborcsardi merged commit c462fb7 into r-lib:master Apr 8, 2019
@gaborcsardi
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaborcsardi gaborcsardi gaborcsardi requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

set RGL_USE_NULL=TRUE to avoid install errors for packages depending on rgl
2 participants
@jefferis @gaborcsardi