Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra GitLab access token #363

Merged
merged 4 commits into from Jun 6, 2019
Merged

Remove extra GitLab access token #363

merged 4 commits into from Jun 6, 2019

Conversation

aornugent
Copy link
Contributor

@aornugent aornugent commented May 8, 2019

Fixes small bug noted here: #355 (comment)

GitLab access token gets added to the API call in two places. This removes one.

@jimhester jimhester merged commit cd27914 into r-lib:master Jun 6, 2019
0 of 2 checks passed
@jimhester
Copy link
Member

@jimhester jimhester commented Jun 6, 2019

Great work, this package is now better thanks to you!

Thanks!! You are da bomb!

@dpprdan
Copy link
Contributor

@dpprdan dpprdan commented Jun 6, 2019

@jimhester 👍
It might be worth mentioning #359 in NEWS as well - or instead of this, since this PR here fixes a bug in #359 which was introduced after 2.0.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants