Skip to content

trim trailing ws in versioned deps#366

Merged
jimhester merged 3 commits into
r-lib:masterfrom
LiNk-NY:master
May 28, 2019
Merged

trim trailing ws in versioned deps#366
jimhester merged 3 commits into
r-lib:masterfrom
LiNk-NY:master

Conversation

@LiNk-NY

@LiNk-NY LiNk-NY commented May 13, 2019

Copy link
Copy Markdown
Contributor

I'm getting issues with a space in the version comparison operator <.
I have added a work-around. Preferably this would be handled in the regexp but
I wasn't able to work with it.
@gaborcsardi @jimhester
Thanks,
Marcel

@jimhester

Copy link
Copy Markdown
Member

Could you include a test with the example of a dependency that breaks with the current code?

@LiNk-NY

LiNk-NY commented May 14, 2019

Copy link
Copy Markdown
Contributor Author

Here it is @jimhester @gaborcsardi :

library(remotes)
install_github("Bioconductor/BiocWorkshops2019")
#> Downloading GitHub repo Bioconductor/BiocWorkshops2019@master
#> Error in FUN(X[[i]], ...): Invalid comparison operator in dependency: <

Created on 2019-05-14 by the reprex package (v0.2.1)

Code

Depends: R (>= 3.6.0), R (< 3.7.0) 

See: https://github.com/Bioconductor/BiocWorkshops2019/blob/master/DESCRIPTION

@LiNk-NY

LiNk-NY commented May 15, 2019

Copy link
Copy Markdown
Contributor Author

Hi Jim, @jimhester
I didn't immediately understand the tests comment 😅. But now I've added a test to the package with the offending code.
I also updated the regex code in the package that gets to the bottom of the issue.

Thanks,
Marcel

@LiNk-NY LiNk-NY changed the title trimws around operators in versioned deps trim trailing ws in versioned deps May 15, 2019
@jimhester

Copy link
Copy Markdown
Member

Thanks, it looks good! Can you please add a bullet to NEWS? It should briefly describe the change and end with (@yourname, #issuenumber).

@LiNk-NY

LiNk-NY commented May 16, 2019

Copy link
Copy Markdown
Contributor Author

Hi Jim, @jimhester
It's ready.
Best,
Marcel

@jimhester

Copy link
Copy Markdown
Member

Great work, this package is now better thanks to you!

Thanks!! You are da bomb!

@jimhester jimhester merged commit 2557041 into r-lib:master May 28, 2019
@LiNk-NY

LiNk-NY commented May 28, 2019

Copy link
Copy Markdown
Contributor Author

Thanks Jim!

@clauwald

Copy link
Copy Markdown

image

@LiNk-NY LiNk-NY deleted the master branch December 29, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants