Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trim trailing ws in versioned deps #366

Merged
merged 3 commits into from May 28, 2019
Merged

trim trailing ws in versioned deps #366

merged 3 commits into from May 28, 2019

Conversation

LiNk-NY
Copy link
Contributor

@LiNk-NY LiNk-NY commented May 13, 2019

I'm getting issues with a space in the version comparison operator <.
I have added a work-around. Preferably this would be handled in the regexp but
I wasn't able to work with it.
@gaborcsardi @jimhester
Thanks,
Marcel

@jimhester
Copy link
Member

jimhester commented May 14, 2019

Could you include a test with the example of a dependency that breaks with the current code?

@LiNk-NY
Copy link
Contributor Author

LiNk-NY commented May 14, 2019

Here it is @jimhester @gaborcsardi :

library(remotes)
install_github("Bioconductor/BiocWorkshops2019")
#> Downloading GitHub repo Bioconductor/BiocWorkshops2019@master
#> Error in FUN(X[[i]], ...): Invalid comparison operator in dependency: <

Created on 2019-05-14 by the reprex package (v0.2.1)

Code

Depends: R (>= 3.6.0), R (< 3.7.0) 

See: https://github.com/Bioconductor/BiocWorkshops2019/blob/master/DESCRIPTION

@LiNk-NY
Copy link
Contributor Author

LiNk-NY commented May 15, 2019

Hi Jim, @jimhester
I didn't immediately understand the tests comment 😅. But now I've added a test to the package with the offending code.
I also updated the regex code in the package that gets to the bottom of the issue.

Thanks,
Marcel

@LiNk-NY LiNk-NY changed the title trimws around operators in versioned deps trim trailing ws in versioned deps May 15, 2019
@jimhester
Copy link
Member

jimhester commented May 16, 2019

Thanks, it looks good! Can you please add a bullet to NEWS? It should briefly describe the change and end with (@yourname, #issuenumber).

@LiNk-NY
Copy link
Contributor Author

LiNk-NY commented May 16, 2019

Hi Jim, @jimhester
It's ready.
Best,
Marcel

@jimhester
Copy link
Member

jimhester commented May 28, 2019

Great work, this package is now better thanks to you!

Thanks!! You are da bomb!

@jimhester jimhester merged commit 2557041 into r-lib:master May 28, 2019
2 checks passed
@LiNk-NY
Copy link
Contributor Author

LiNk-NY commented May 28, 2019

Thanks Jim!

@clauwald
Copy link

clauwald commented May 28, 2019

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants