Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add regression test for issue #646 and fixup git_remote #658

Merged
merged 2 commits into from
Oct 19, 2021
Merged

add regression test for issue #646 and fixup git_remote #658

merged 2 commits into from
Oct 19, 2021

Conversation

achimgaedke
Copy link
Contributor

This addresses #646 - I've fixed the regular expression to the best of my knowledge (guided by the issue and the existing regression tests).

Please review the test cases and add some more if necessary.

@achimgaedke
Copy link
Contributor Author

achimgaedke commented Oct 17, 2021 •
edited
Loading

Hmmm. The failures exist in master as well and are probably unrelated to this PR.

fixed (ran make and checked in result in as separate commit)

@achimgaedke achimgaedke changed the title add regression for issue 646 and fixup install-git::git_remote add regression for issue #646 and fixup install-git::git_remote Oct 17, 2021
@achimgaedke achimgaedke changed the title add regression for issue #646 and fixup install-git::git_remote add regression test for issue #646 and fixup git_remote Oct 17, 2021
@jimhester
Copy link
Member

jimhester commented Oct 18, 2021 •
edited
Loading

Thanks!

Can you please add a bullet to NEWS? It should briefly describe the change and end with (@yourname, #issuenumber).

@achimgaedke
Copy link
Contributor Author

@jimhester - this is done now

@jimhester jimhester merged commit eb15a1e into r-lib:master Oct 19, 2021
@jimhester
Copy link
Member

Thank you!

@achimgaedke achimgaedke mentioned this pull request Oct 20, 2021
Closed
@riccardoporreca riccardoporreca mentioned this pull request Nov 2, 2021
Merged
@wfulp wfulp mentioned this pull request Jan 11, 2022
Open
@ThomUK ThomUK mentioned this pull request Jun 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@achimgaedke @jimhester