Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alpha() only works when color is opaque #2

Closed
yihui opened this issue Jul 24, 2011 · 2 comments
Closed

alpha() only works when color is opaque #2

yihui opened this issue Jul 24, 2011 · 2 comments

Comments

@yihui
Copy link
Contributor

yihui commented Jul 24, 2011

what is the reasoning behind this? https://github.com/hadley/scales/blob/master/R/colour-manip.r#L66

I thought alpha() could change the alpha transparency of any colors...
@hadley
Copy link
Member

hadley commented Jul 26, 2011

Hmmmm, I'm not sure if I remember. I think it's a hold over from ggplot2 where you can set alpha and colour separately, and the alpha on the colour overrules the alpha aesthetic. This can probably be removed now - do you want to submit a pull request?

@yihui
Copy link
Contributor Author

yihui commented Jul 26, 2011

Done.

@yihui yihui closed this as completed Jul 26, 2011
kohske pushed a commit to kohske/scales that referenced this issue Dec 17, 2011
@hadley
Merge pull request r-lib#3 from yihui/master
d7dca89 
Modify colours with alpha set (fixes r-lib#2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hadley @yihui