Additional arguments for scientific_format() #147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larmarange
force-pushed
the
scientific_format
branch
from
4ec4a49 to
ab48691
Compare
hadley
reviewed
Jul 7, 2018
Member
hadley
left a comment
hadley
left a comment
There was a problem hiding this comment.
Do we want to add scale here too?
R/formatter.r
Outdated
| #' scientific(12345, suffix = " cells/mL") | ||
| scientific_format <- function(digits = 3, prefix = "", suffix = "", | ||
| decimal.mark = ".", trim = TRUE, ...) { | ||
| force_all(digits, ...) |
Member
There was a problem hiding this comment.
This now needs to include prefix, suffix, etc.
Consistent with the arguments introduced by `number_format()`
larmarange
force-pushed
the
scientific_format
branch
from
ab48691 to
c367b02
Compare
Contributor
Author
|
|
Member
|
Thanks! |
1 similar comment
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consistent with the arguments introduced by
number_format()