New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional arguments for scientific_format() #147

Merged
merged 1 commit into from Jul 7, 2018

Conversation

Projects
None yet
2 participants
@larmarange
Contributor

larmarange commented Jul 7, 2018

Consistent with the arguments introduced by number_format()

@larmarange larmarange force-pushed the larmarange:scientific_format branch from 4ec4a49 to ab48691 Jul 7, 2018

@hadley

Do we want to add scale here too?

scientific_format <- function(digits = 3, ...) {
#' scientific(12345, suffix = " cells/mL")
scientific_format <- function(digits = 3, prefix = "", suffix = "",
decimal.mark = ".", trim = TRUE, ...) {
force_all(digits, ...)

This comment has been minimized.

@hadley

hadley Jul 7, 2018

Member

This now needs to include prefix, suffix, etc.

Additional arguments for scientific_format()
Consistent with the arguments introduced by `number_format()`

@larmarange larmarange force-pushed the larmarange:scientific_format branch from ab48691 to c367b02 Jul 7, 2018

@larmarange

This comment has been minimized.

Contributor

larmarange commented Jul 7, 2018

scale has been added (with new tests) and news bullet done

@hadley hadley merged commit 32e6d55 into r-lib:master Jul 7, 2018

3 checks passed

codecov/patch 100% of diff hit (target 66.66%)
Details
codecov/project 67.11% (+0.44%) compared to 8257643
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hadley

This comment has been minimized.

Member

hadley commented Jul 7, 2018

Thanks!

1 similar comment
@hadley

This comment has been minimized.

Member

hadley commented Jul 7, 2018

Thanks!

@larmarange larmarange deleted the larmarange:scientific_format branch Jul 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment