Add na.rm support to DiscreteRange$train #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@clauswilke are you concerned by the failing check? looks to be related to a warning regarding links on the brewer_pal documentation. Not entirely sure what's going on there but it's definitely unrelated to this PR. If not, I'll merge. |
|
Cross-references in documentation are an ongoing drama, but that shouldn't hold up this PR. Not sure why it hits this particular test, but maybe just because {plyr} isn't currently available for R devel. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DiscreteRange train function does not currently support the
na.rmargument totrain_discrete, preventing its direct use to replace ggplot2's range functions (tidyverse/ggplot2#2710). This PR updates the train function to support this argument.