Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider storing code tree structure for tests by default #1206

Closed
IndrajeetPatil opened this issue May 12, 2024 · 2 comments · Fixed by #1208
Closed

Reconsider storing code tree structure for tests by default #1206

IndrajeetPatil opened this issue May 12, 2024 · 2 comments · Fixed by #1208

Comments

@IndrajeetPatil
Copy link
Collaborator

That is, consider whether setting write_tree = FALSE in test_collection(), and maybe turn it on to TRUE only in interactive contexts where these structures might help debug some issue?

The current approach tends to produce large git diffs for even minor changes in test code.

Is there any downside to doing so?

@lorenzwalthert
Copy link
Collaborator

Taking a closer look at the diff, many seem unrelated to your changes, and more related to some changes in {data.tree} or the parser itself.
Screenshot 2024-05-13 at 10 03 32

I have hardly ever used these tree files in practice. And they are also .Rbuildignored. I think people can generate them if they need, as you said, so we could .gitignore them and make the default write_tree = FALSE (currently NA, which accounted for the fact that {data.tree} is only available for R >= 3.2, which is irrelevant nowadays).

@lorenzwalthert
Copy link
Collaborator

Once this is done, we can rebase #1195 on main to avoid its large tree diff.

IndrajeetPatil added a commit that referenced this issue May 13, 2024
closes #1206

And also remove everything that was needed for R 3.2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants