Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use nrow arg in new_tibble() calls #1003

Merged
merged 4 commits into from
Sep 20, 2022
Merged

Don't use nrow arg in new_tibble() calls #1003

merged 4 commits into from
Sep 20, 2022

Conversation

IndrajeetPatil
Copy link
Collaborator

We are unnecessarily repeating ourselves by doing this.

We are unnecessarily repeating ourselves by doing this.
@codecov-commenter
Copy link

Codecov Report

Merging #1003 (8707064) into main (08da821) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1003      +/-   ##
==========================================
- Coverage   90.26%   90.25%   -0.02%     
==========================================
  Files          47       47              
  Lines        2682     2679       -3     
==========================================
- Hits         2421     2418       -3     
  Misses        261      261              
Impacted Files Coverage Δ
R/nest.R 100.00% <ø> (ø)
R/token-create.R 96.07% <ø> (-0.08%) ⬇️
R/compat-dplyr.R 92.85% <100.00%> (ø)
R/compat-tidyr.R 100.00% <100.00%> (ø)
R/transform-files.R 97.29% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 7283800 is merged into main:

  •   :ballot_box_with_check:cache_applying: 31.8ms -> 31.8ms [-1.69%, +1.96%]
  •   :ballot_box_with_check:cache_recording: 1.51s -> 1.49s [-3.14%, +0.09%]
  •   :ballot_box_with_check:without_cache: 3.89s -> 3.89s [-0.47%, +0.65%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if b64e331 is merged into main:

  •   :ballot_box_with_check:cache_applying: 30.6ms -> 30.3ms [-2.65%, +0.81%]
  • ❗🐌cache_recording: 1.4s -> 1.42s [+0.56%, +2.15%]
  • ❗🐌without_cache: 3.66s -> 3.72s [+0.79%, +2.39%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@IndrajeetPatil IndrajeetPatil removed the request for review from lorenzwalthert September 19, 2022 14:00
@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 3642e31 is merged into main:

  •   :ballot_box_with_check:cache_applying: 30.5ms -> 30.6ms [-0.7%, +1.48%]
  •   :ballot_box_with_check:cache_recording: 1.41s -> 1.41s [-0.99%, +0.08%]
  •   :ballot_box_with_check:without_cache: 3.7s -> 3.7s [-0.38%, +0.34%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@IndrajeetPatil IndrajeetPatil changed the title Don't use nrow arg in new_tibble() calls WIP: Don't use nrow arg in new_tibble() calls Sep 19, 2022
@lorenzwalthert
Copy link
Collaborator

Thanks. I think initially you had to supply Tue length j that constructor, maybe not anymore. Is that still wip?

@IndrajeetPatil
Copy link
Collaborator Author

Ah, I marked it WIP only because I didn't see much of a performance improvement so wasn't sure if this is worth a merge.

@IndrajeetPatil IndrajeetPatil changed the title WIP: Don't use nrow arg in new_tibble() calls Don't use nrow arg in new_tibble() calls Sep 20, 2022
@IndrajeetPatil IndrajeetPatil merged commit 32702ae into r-lib:main Sep 20, 2022
@IndrajeetPatil IndrajeetPatil deleted the rm_unneeded_arg branch September 20, 2022 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants