Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename internal function set_linebreak_after_ggplot2_plus() to set_line_break_after_ggplot2_plus() #1049

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

Polkas
Copy link
Contributor

@Polkas Polkas commented Nov 3, 2022

closes #1048

Now all set_line_break_* functions have consistent naming.

As the set_linebreak_after_ggplot2_plus is not exported I think we do not have to add the record to the NEWS file i.e. add the */- to the commit message.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2022

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 53e52d8 is merged into main:

  •   :ballot_box_with_check:cache_applying: 46ms -> 45.7ms [-7.97%, +6.54%]
  •   :ballot_box_with_check:cache_recording: 1.47s -> 1.5s [-4.89%, +9.42%]
  •   :ballot_box_with_check:without_cache: 3.88s -> 3.71s [-10%, +1.2%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@IndrajeetPatil IndrajeetPatil changed the title rename the not exported set_linebreak_after_ggplot2_plus to be consis… Rename internal function set_linebreak_after_ggplot2_plus() to set_line_break_after_ggplot2_plus() Nov 7, 2022
Copy link
Collaborator

@IndrajeetPatil IndrajeetPatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@IndrajeetPatil IndrajeetPatil merged commit 29599f1 into r-lib:main Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set line break naming not consistent
2 participants