Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no pkgdown pre-commit action with GitHub Actions #1081

Merged
merged 2 commits into from
Dec 24, 2022

Conversation

lorenzwalthert
Copy link
Collaborator

@lorenzwalthert lorenzwalthert commented Dec 24, 2022

We already have the pkgdown action. This should be added to the template in lorenzwalthert/precommit.

We already have the pkgdown action
@codecov-commenter
Copy link

codecov-commenter commented Dec 24, 2022

Codecov Report

Merging #1081 (589cbe9) into main (0314644) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1081   +/-   ##
=======================================
  Coverage   91.05%   91.05%           
=======================================
  Files          46       46           
  Lines        2684     2684           
=======================================
  Hits         2444     2444           
  Misses        240      240           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@IndrajeetPatil IndrajeetPatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. It's a bit redundant in our workflow.

@IndrajeetPatil IndrajeetPatil merged commit 509bea1 into main Dec 24, 2022
@IndrajeetPatil IndrajeetPatil deleted the lorenzwalthert-patch-1 branch December 24, 2022 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants