Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up unnecessary YAML front matter in README #1165

Merged
merged 3 commits into from
Dec 5, 2023
Merged

Conversation

IndrajeetPatil
Copy link
Collaborator

Correct me if I am wrong, but I don't think this is adding much here.

@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cb33e89) 92.16% compared to head (9587678) 92.16%.

❗ Current head 9587678 differs from pull request most recent head 385e316. Consider uploading reports for the commit 385e316 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1165   +/-   ##
=======================================
  Coverage   92.16%   92.16%           
=======================================
  Files          46       46           
  Lines        2655     2655           
=======================================
  Hits         2447     2447           
  Misses        208      208           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IndrajeetPatil
Copy link
Collaborator Author

The precommit workflow will be fixed after #1166 is merged.

@lorenzwalthert
Copy link
Collaborator

Can you toggle visual mode in RStudio? I think part of it comes from that, at least the line length stuff...

@IndrajeetPatil
Copy link
Collaborator Author

Can you toggle visual mode in RStudio? I think part of it comes from that, at least the line length stuff...

Okay, I've retained the fields relevant for Visual markdown editor.

This PR still needs to wait for #1166 to be merged.

@lorenzwalthert lorenzwalthert merged commit 10efce2 into main Dec 5, 2023
14 of 15 checks passed
@IndrajeetPatil IndrajeetPatil deleted the reknit-readme branch December 5, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants