Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong for loop indention for scope = "spaces" #457

Merged
merged 1 commit into from Jan 5, 2019

Conversation

@lorenzwalthert
Copy link
Collaborator

commented Jan 5, 2019

Closes #456 by checking if a new line follows after token, as we should do for all space manipulators to preserve indention for the case the raw indention should be used.

@codecov-io

This comment has been minimized.

Copy link

commented Jan 5, 2019

Codecov Report

Merging #457 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #457   +/-   ##
=======================================
  Coverage   90.73%   90.73%           
=======================================
  Files          36       36           
  Lines        1629     1629           
=======================================
  Hits         1478     1478           
  Misses        151      151
Impacted Files Coverage Δ
R/rules-spacing.R 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86003a0...88e63a7. Read the comment docs.

@lorenzwalthert lorenzwalthert merged commit c239bd1 into r-lib:master Jan 5, 2019

4 checks passed

codecov/patch 100% of diff hit (target 90.73%)
Details
codecov/project 90.73% (+0%) compared to 86003a0
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@lorenzwalthert lorenzwalthert deleted the lorenzwalthert:fix-indent-nested-for branch Jan 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.