Skip to content

Fix wrong for loop indention for scope = "spaces"#457

Merged
lorenzwalthert merged 1 commit intor-lib:masterfrom
lorenzwalthert:fix-indent-nested-for
Jan 5, 2019
Merged

Fix wrong for loop indention for scope = "spaces"#457
lorenzwalthert merged 1 commit intor-lib:masterfrom
lorenzwalthert:fix-indent-nested-for

Conversation

@lorenzwalthert
Copy link
Copy Markdown
Collaborator

Closes #456 by checking if a new line follows after token, as we should do for all space manipulators to preserve indention for the case the raw indention should be used.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 5, 2019

Codecov Report

Merging #457 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #457   +/-   ##
=======================================
  Coverage   90.73%   90.73%           
=======================================
  Files          36       36           
  Lines        1629     1629           
=======================================
  Hits         1478     1478           
  Misses        151      151
Impacted Files Coverage Δ
R/rules-spacing.R 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86003a0...88e63a7. Read the comment docs.

@lorenzwalthert lorenzwalthert merged commit c239bd1 into r-lib:master Jan 5, 2019
@lorenzwalthert lorenzwalthert deleted the fix-indent-nested-for branch January 5, 2019 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants