Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark study: Implicit imports #685

Closed
wants to merge 4 commits into from

Conversation

lorenzwalthert
Copy link
Collaborator

@lorenzwalthert lorenzwalthert commented Oct 25, 2020

Remove the majority of package prefixes to see if it brings speed gain.

5dc4a45

  • cache_appyling: 0.106477 -> 0.10819 (2%)
  • cache_recording: 1.58938 -> 1.65327 (4%)
  • without_cache: 4.31798 -> 4.32099 (0%)

e59073a

  • cache_appyling: 0.10285 -> 0.0910904 (-11%)
  • cache_recording: 1.33579 -> 1.18051 (-12%)
  • without_cache: 3.41733 -> 3.06976 (-10%)

697d4b5

  • cache_appyling: 0.10285 -> 0.101439 (-1%)
  • cache_recording: 1.33579 -> 1.33368 (0%)
  • without_cache: 3.41733 -> 3.52667 (3%)

with https://github.com/lorenzwalthert/touchstone

  • cache_applying: 0.03 -> 0.03 (-12.2%)
  • cache_recording: 1.01 -> 1 (-1.4%)
  • without_cache: 2.97 -> 2.95 (-0.6%)

@codecov-io
Copy link

codecov-io commented Oct 25, 2020

Codecov Report

Merging #685 (fd6829c) into master (d5b8b0e) will increase coverage by 0.00%.
The diff coverage is 83.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #685   +/-   ##
=======================================
  Coverage   90.43%   90.44%           
=======================================
  Files          47       47           
  Lines        2248     2250    +2     
=======================================
+ Hits         2033     2035    +2     
  Misses        215      215           
Impacted Files Coverage Δ
R/addins.R 0.00% <0.00%> (ø)
R/utils.R 82.75% <0.00%> (ø)
R/io.R 88.23% <75.00%> (+0.48%) ⬆️
R/compat-dplyr.R 85.71% <100.00%> (ø)
R/parse.R 85.55% <100.00%> (ø)
R/roxygen-examples-find.R 100.00% <100.00%> (ø)
R/roxygen-examples-parse.R 100.00% <100.00%> (ø)
R/rules-spacing.R 98.46% <100.00%> (ø)
R/style-guides.R 100.00% <100.00%> (ø)
R/ui-caching.R 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5b8b0e...fd6829c. Read the comment docs.

@lorenzwalthert
Copy link
Collaborator Author

cc: @krlmlr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants