Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.6.2 #842

Merged
merged 12 commits into from
Sep 25, 2021
Merged

Release 1.6.2 #842

merged 12 commits into from
Sep 25, 2021

Conversation

lorenzwalthert
Copy link
Collaborator

@lorenzwalthert lorenzwalthert commented Sep 22, 2021

Prepare for release:

  • devtools::check_win_devel()
  • Polish NEWS
  • If new failures, update email.yml then revdepcheck::revdep_email_maintainers()
  • update cran-comments.md
  • run urlchecker::url_check("path/to/pkg")

Perform release:

  • Create RC branch (for bigger releases)
  • Bump version (in DESCRIPTION and NEWS)
  • add tidy thanks to NEWS.md
  • devtools::submit_cran()
  • pkgdown::build_site()
  • Approve email

Wait for CRAN...

  • Tag release
  • Merge RC back to master branch
  • Bump dev version
  • update CRAN speed change monitor PR.We have a new CRAN release coming up 馃コ See NEWS.md for new features.

Prepare for release:

  • devtools::check_win_devel()
  • Polish NEWS
  • If new failures, update email.yml then revdepcheck::revdep_email_maintainers()
  • update cran-comments.md

Perform release:

  • Create RC branch (for bigger releases)
  • Bump version (in DESCRIPTION and NEWS)
  • add tidy thanks to NEWS.md
  • devtools::submit_cran()
  • pkgdown::build_site()
  • Approve email

Wait for CRAN...

  • Tag release
  • Merge RC back to master branch
  • Bump dev version
  • update CRAN speed change monitor PR.

@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2021

Codecov Report

Merging #842 (91b6aaf) into master (0e41d88) will increase coverage by 0.39%.
The diff coverage is 0.00%.

鉂 Current head 91b6aaf differs from pull request most recent head 580031b. Consider uploading reports for the commit 580031b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #842      +/-   ##
==========================================
+ Coverage   89.46%   89.85%   +0.39%     
==========================================
  Files          47       47              
  Lines        2496     2485      -11     
==========================================
  Hits         2233     2233              
+ Misses        263      252      -11     
Impacted Files Coverage 螖
R/nest.R 100.00% <酶> (酶)
R/utils-cache.R 100.00% <酶> (酶)
R/zzz.R 0.00% <0.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 0e41d88...580031b. Read the comment docs.

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if f66a7cd is merged into master:

  • 聽聽:rocket:cache_applying: 29.8ms -> 27.2ms [-10.84%, -6.64%]
  • 鉂楌煇宑ache_recording: 1.11s -> 1.12s [+0.1%, +1.16%]
  • 鉂楌煇寃ithout_cache: 2.85s -> 2.91s [+1.69%, +2.36%]

Further explanation regarding interpretation and methodology can be found in the documentation.

Copy link
Member

@krlmlr krlmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hope it survives.

R/zzz.R Outdated
Comment on lines 40 to 42
if (length(dirs) < 1) {
return()
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this shortcut (and the one below)?

R/zzz.R Outdated Show resolved Hide resolved
R/zzz.R Outdated Show resolved Hide resolved
lorenzwalthert and others added 5 commits September 22, 2021 21:49
Co-authored-by: Kirill M眉ller <krlmlr@users.noreply.github.com>
Co-authored-by: Kirill M眉ller <krlmlr@users.noreply.github.com>
@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if c0e2c93 is merged into master:

  • 鉂楌煇宑ache_applying: 25.6ms -> 26.8ms [+1.71%, +7.76%]
  • 聽聽:ballot_box_with_check:cache_recording: 940ms -> 937ms [-1.76%, +1.06%]
  • 鉂楌煇寃ithout_cache: 2.38s -> 2.43s [+1.11%, +3.12%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@lorenzwalthert lorenzwalthert merged commit 9305b62 into r-lib:master Sep 25, 2021
@lorenzwalthert lorenzwalthert deleted the rc-1.6.2 branch September 25, 2021 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants