Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix touchstone #902

Merged
merged 3 commits into from
Jan 15, 2022
Merged

Fix touchstone #902

merged 3 commits into from
Jan 15, 2022

Conversation

lorenzwalthert
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2022

Codecov Report

Merging #902 (b02e471) into main (70e764f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #902   +/-   ##
=======================================
  Coverage   90.33%   90.33%           
=======================================
  Files          47       47           
  Lines        2546     2546           
=======================================
  Hits         2300     2300           
  Misses        246      246           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70e764f...b02e471. Read the comment docs.

@assignUser
Copy link

@lorenzwalthert it looks like the comment action was triggered with the .yaml from main https://github.com/r-lib/styler/actions/runs/1702426418/workflow
no idea if it's possible to force that or if you need to merge this first...

@lorenzwalthert
Copy link
Collaborator Author

@assignUser I think it's triggered from main - and by design. Otherwise, I could just PR to a random repo and execute random code with their credentials, no?

@lorenzwalthert lorenzwalthert merged commit 10b064b into r-lib:main Jan 15, 2022
@lorenzwalthert lorenzwalthert deleted the toucstone-action branch January 15, 2022 20:30
@assignUser
Copy link

@lorenzwalthert Oh yeah, that makes sense for files with the workflow trigger!

@lorenzwalthert
Copy link
Collaborator Author

Every merge to main triggers a new touchstone CI run because I want to see how merge main into latest release changes the performance of the released version with #868, so we'll see.

@lorenzwalthert lorenzwalthert mentioned this pull request Mar 12, 2022
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants