Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new R option to ignore alignment #932

Merged
merged 6 commits into from
Mar 24, 2022
Merged

new R option to ignore alignment #932

merged 6 commits into from
Mar 24, 2022

Conversation

lorenzwalthert
Copy link
Collaborator

Closes #834.

@codecov-commenter
Copy link

Codecov Report

Merging #932 (7c3bca7) into main (aa32091) will decrease coverage by 0.03%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main     #932      +/-   ##
==========================================
- Coverage   90.48%   90.45%   -0.04%     
==========================================
  Files          47       47              
  Lines        2585     2587       +2     
==========================================
+ Hits         2339     2340       +1     
- Misses        246      247       +1     
Impacted Files Coverage Δ
R/zzz.R 38.63% <0.00%> (-0.90%) ⬇️
R/rules-spaces.R 98.33% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa32091...7c3bca7. Read the comment docs.

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 1846e3a is merged into main:

  •   :ballot_box_with_check:cache_applying: 25.8ms -> 25.7ms [-1.38%, +0.46%]
  •   :rocket:cache_recording: 1.12s -> 1.12s [-0.62%, -0.1%]
  • ❗🐌without_cache: 3.03s -> 3.04s [+0.08%, +0.6%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if a80037c is merged into main:

  •   :ballot_box_with_check:cache_applying: 28.3ms -> 28.8ms [-1.13%, +4.91%]
  •   :ballot_box_with_check:cache_recording: 1.45s -> 1.46s [-2.19%, +3.49%]
  •   :ballot_box_with_check:without_cache: 3.88s -> 3.89s [-0.33%, +1.03%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 06a41cd is merged into main:

  •   :ballot_box_with_check:cache_applying: 24.9ms -> 24.8ms [-2.66%, +1.48%]
  •   :ballot_box_with_check:cache_recording: 1.03s -> 1.02s [-3.37%, +1.67%]
  •   :ballot_box_with_check:without_cache: 2.96s -> 2.96s [-0.64%, +0.46%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@lorenzwalthert lorenzwalthert merged commit eec45e4 into main Mar 24, 2022
@lorenzwalthert lorenzwalthert deleted the issue-834 branch May 17, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add option to not detect alignment
2 participants