-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused internal utilities #989
Conversation
@@ -48,24 +48,13 @@ two_cols_match <- function(col1, col2, data) { | |||
all(unlist(data[col1]) == unlist(data[col2])) | |||
} | |||
|
|||
odd <- function(x) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are odd_index/even_index still used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, they are.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw I wonder if {lintr} should offer such a check, i.e. if all symbols are used. Does it already?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have created an issue to track this: r-lib/lintr#1513
We currently have only unused_import_linter(), but it'd be good to also have something like unused_internal_object()
linter.
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 1e96379 is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
Thanks @IndrajeetPatil. Until we use {fledge}, can you please also add a new bullet for this and your previous contributions? I'll merge afterwards. |
Thanks @IndrajeetPatil for this contribution 🚀 . |
This is how benchmark results would change (along with a 95% confidence interval in relative change) if c01a2ab is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
No description provided.