Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused internal utilities #989

Merged
merged 3 commits into from
Aug 26, 2022
Merged

Remove unused internal utilities #989

merged 3 commits into from
Aug 26, 2022

Conversation

IndrajeetPatil
Copy link
Collaborator

No description provided.

@IndrajeetPatil IndrajeetPatil marked this pull request as ready for review August 25, 2022 16:44
@@ -48,24 +48,13 @@ two_cols_match <- function(col1, col2, data) {
all(unlist(data[col1]) == unlist(data[col2]))
}

odd <- function(x) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are odd_index/even_index still used?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, they are.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw I wonder if {lintr} should offer such a check, i.e. if all symbols are used. Does it already?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have created an issue to track this: r-lib/lintr#1513

We currently have only unused_import_linter(), but it'd be good to also have something like unused_internal_object() linter.

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 1e96379 is merged into main:

  •   :ballot_box_with_check:cache_applying: 36.2ms -> 35.7ms [-4.36%, +1.25%]
  •   :ballot_box_with_check:cache_recording: 1.88s -> 1.86s [-1.72%, +0.16%]
  •   :ballot_box_with_check:without_cache: 4.94s -> 4.98s [-0.13%, +2.09%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@lorenzwalthert
Copy link
Collaborator

Thanks @IndrajeetPatil. Until we use {fledge}, can you please also add a new bullet for this and your previous contributions? I'll merge afterwards.

@lorenzwalthert lorenzwalthert merged commit 62db63d into r-lib:main Aug 26, 2022
@lorenzwalthert
Copy link
Collaborator

Thanks @IndrajeetPatil for this contribution 🚀 .

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if c01a2ab is merged into main:

  •   :ballot_box_with_check:cache_applying: 28.8ms -> 28.8ms [-1.7%, +1.12%]
  •   :ballot_box_with_check:cache_recording: 1.3s -> 1.3s [-1.07%, +0.59%]
  •   :ballot_box_with_check:without_cache: 3.44s -> 3.45s [-0.65%, +1.19%]

Further explanation regarding interpretation and methodology can be found in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants