-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use integer literals and avoid coercions where needed #994
Conversation
Codecov Report
@@ Coverage Diff @@
## main #994 +/- ##
==========================================
+ Coverage 90.23% 90.34% +0.11%
==========================================
Files 47 47
Lines 2694 2694
==========================================
+ Hits 2431 2434 +3
+ Misses 263 260 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow thanks @IndrajeetPatil for that hard work. Will review in detail later
This is how benchmark results would change (along with a 95% confidence interval in relative change) if f8644ab is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 2569a3a is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nothing to add. Just a thank you.
As mentioned here: