Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Don't preserve names for unlist() #998

Merged
merged 5 commits into from
Sep 13, 2022
Merged

perf: Don't preserve names for unlist() #998

merged 5 commits into from
Sep 13, 2022

Conversation

IndrajeetPatil
Copy link
Collaborator

@IndrajeetPatil IndrajeetPatil commented Sep 13, 2022

This should be slightly faster than using the unlist() default arguments.

@github-actions

This comment was marked as outdated.

@IndrajeetPatil

This comment was marked as outdated.

@IndrajeetPatil IndrajeetPatil changed the title Check if names need to preserved for unlist() perf: Don't preserve names for unlist() Sep 13, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #998 (2d6fc68) into main (4049885) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 2d6fc68 differs from pull request most recent head 2d7075a. Consider uploading reports for the commit 2d7075a to get more accurate results

@@            Coverage Diff             @@
##             main     #998      +/-   ##
==========================================
- Coverage   90.24%   90.23%   -0.02%     
==========================================
  Files          47       47              
  Lines        2697     2694       -3     
==========================================
- Hits         2434     2431       -3     
  Misses        263      263              
Impacted Files Coverage Δ
R/utils-cache.R 100.00% <ø> (ø)
R/nest.R 100.00% <100.00%> (ø)
R/parse.R 88.09% <100.00%> (-0.15%) ⬇️
R/stylerignore.R 100.00% <100.00%> (ø)
R/transform-block.R 100.00% <100.00%> (ø)
R/transform-files.R 97.29% <100.00%> (ø)
R/utils-files.R 100.00% <100.00%> (ø)
R/utils.R 88.46% <100.00%> (-0.43%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 897a429 is merged into main:

  •   :ballot_box_with_check:cache_applying: 26ms -> 26.1ms [-2.4%, +3%]
  •   :ballot_box_with_check:cache_recording: 1.25s -> 1.23s [-4.52%, +0.56%]
  •   :ballot_box_with_check:without_cache: 3.25s -> 3.21s [-3.56%, +1.33%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@lorenzwalthert
Copy link
Collaborator

@IndrajeetPatil you can merge, please beware that we now use {fledge} for release management and hence I'd suggest to ensure a merge commit message you want to appear in the changeling afterwards.

@IndrajeetPatil IndrajeetPatil merged commit 042624e into r-lib:main Sep 13, 2022
@IndrajeetPatil IndrajeetPatil deleted the unlist_names branch September 13, 2022 13:31
@krlmlr
Copy link
Member

krlmlr commented Sep 13, 2022

FTR, the PR title will be shown very nicely in NEWS.md . I can soon add a workflow that will bump the version regularly so that we don't need to do this manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants