-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: Don't preserve names for unlist()
#998
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
unlist()
unlist()
Codecov Report
@@ Coverage Diff @@
## main #998 +/- ##
==========================================
- Coverage 90.24% 90.23% -0.02%
==========================================
Files 47 47
Lines 2697 2694 -3
==========================================
- Hits 2434 2431 -3
Misses 263 263
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 897a429 is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
@IndrajeetPatil you can merge, please beware that we now use {fledge} for release management and hence I'd suggest to ensure a merge commit message you want to appear in the changeling afterwards. |
FTR, the PR title will be shown very nicely in |
This should be slightly faster than using the
unlist()
default arguments.