-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds skip_on_gh_actions (resolves #970) #975
Conversation
LGTM |
Co-authored-by: @boshek (Sam Albers) <sam.albers@gov.bc.ca>
@@ -9,6 +9,7 @@ | |||
* Fixed issue where error and warning messages were not retrieved with | |||
`conditionMessage()` under certain circumstances. | |||
|
|||
* Add `skip_on_gh_actions()` helper, to skip tests on GitHub Actions (#970) (@boshek, @njtieney). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please merge/rebase and move the NEWS bullet up?
@njtierney outside of rebasing, could you add the https://github.com/r-lib/testthat/pull/975/files#diff-8118c4bf22b8b996a3b1d49ba32e01feR23-R30 #' `skip_on_ghactions()` skips tests on GitHub Actions by inspecting the
#' `GITHUB_ACTIONS` environment variable.
#' |
Closing since you can just use |
Does |
We set it in our CI actions, which I think will cover 99% of R users. |
Completely stolen the code from #970, but renamed function to
skip_on_gh_actions()
instead ofskip_on_actions()
- please feel free to change!Thanks!