-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(grammar): adapt to upstream regex change #99
Conversation
Can you please point me to the upstream PR for this change? |
tree-sitter/tree-sitter#2838 (EDIT wrong link, sorry about that) |
(you can also just verify this by installing a recent tree-sitter CLI (0.22.5 is latest) and doing |
this is required, else this grammar is unusable in the latest versions |
Changelog is here: https://github.com/tree-sitter/tree-sitter/blob/master/CHANGELOG.md#0220--2024-03-10 (change was made in 0.22.0). |
@DavisVaughan would be nice to get this in (or let me know what I should change) so we can unbreak |
Thanks! |
Thanks @clason, and thanks for committing the minimal amount to get this change in rather than all the new files that come with tree-sitter 0.22+ 😆 (although we will get those updated soon too). |
The day I discovered |
Upstream switched to Rust regex in recent
tree-sitter
, so the commonescape_sequence
pattern/u{[\da-fA-F]+}/
now needs to escape the braces. This fixes:TSInstallFromGrammar
.