Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use_template() no longer errors when a user chooses not to overwrite an existing file and instead produces a message #350

Merged
merged 12 commits into from
Aug 13, 2018
Merged

use_template() no longer errors when a user chooses not to overwrite an existing file and instead produces a message #350

merged 12 commits into from
Aug 13, 2018

Commits on May 14, 2018

  1. a negative user response to overwriting a file produces a message ins… 

    …tead of an error. Closes r-lib#348
    @boshek
    boshek committed May 14, 2018
    Configuration menu
    Copy the full SHA
    75a4f41 View commit details
    Browse the repository at this point in the history

  2. only modify if open = TRUE and the file is actually created

    @boshek
    boshek committed May 14, 2018
    Configuration menu
    Copy the full SHA
    5c7ae8d View commit details
    Browse the repository at this point in the history

  3. modify test_that names to reflect warnings

    @boshek
    boshek committed May 14, 2018
    Configuration menu
    Copy the full SHA
    2f53744 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2018

  1. use longer form comparison

    @boshek
    boshek committed May 28, 2018
    Configuration menu
    Copy the full SHA
    a458e93 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2018

  1. skip R 3.1 when testing message for use_readme overwrite

    @boshek
    boshek committed Jun 1, 2018
    Configuration menu
    Copy the full SHA
    5716b1c View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2018

  1. Tweak docs 

    Also a test to see if I can push to boshek/master
    @jennybc
    jennybc committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    ace9e5a View commit details
    Browse the repository at this point in the history

  2. Swap an if-else

    @jennybc
    jennybc committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    65afc00 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into boshek-master 

    # Conflicts:
#	NEWS.md
#	R/helpers.R
#	R/write.R
#	tests/testthat/test-use-readme.R
#	tests/testthat/test-use-template.R
    @jennybc
    jennybc committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    7fea54b View commit details
    Browse the repository at this point in the history

  4. These functions have moved

    @jennybc
    jennybc committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    1765b4f View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2018

  1. Use done() instead of message()

    @jennybc
    jennybc committed Aug 11, 2018
    Configuration menu
    Copy the full SHA
    94e65d3 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2018

  1. Add expectations for file or dir in the project

    @jennybc
    jennybc committed Aug 12, 2018
    Configuration menu
    Copy the full SHA
    8d1be01 View commit details
    Browse the repository at this point in the history

  2. Finish adjusting to new behaviour or write_over() and use_template()

    @jennybc
    jennybc committed Aug 12, 2018
    Configuration menu
    Copy the full SHA
    9d47752 View commit details
    Browse the repository at this point in the history