Test fixes for dev waldo (#1829)

* Test fixes for dev waldo

Which now actually compares the imaginary part of complex numbers, and flags NaN and NA_real_ as different

* Just test type and missingness in weird `as.complex(NA_real_)` case

In case it changes in base R in the future

* NEWS bullet

* Link to r-devel post

---------

Co-authored-by: DavisVaughan <davis@rstudio.com>

NEWS.md

@@ -1,5 +1,7 @@
 # vctrs (development version)
 
+* Fixed tests to maintain compatibility with the next version of waldo (#1829).
+
 # vctrs 0.6.1
 
 * Fixed a test related to `c.sfc()` changes in sf 1.0-10 (#1817).

tests/testthat/test-set.R

@@ -288,7 +288,7 @@ test_that("works with complex missing values", {
     imaginary = c(NA_real_, NaN, NA_real_, NaN)
   )
   expect_identical(vec_set_symmetric_difference(na, na), complex())
-  expect_identical(vec_set_symmetric_difference(na[-2], na[-4]), na[c(2, 4)])
+  expect_identical(vec_set_symmetric_difference(na[-2], na[-4]), na[c(4, 2)])
 })
 
 test_that("works correctly with unspecified logical vectors", {

tests/testthat/test-type-bare.R

@@ -243,25 +243,36 @@ test_that("safe casts to complex works", {
 })
 
 test_that("NA casts work as expected", {
-  exp <- cpl(NA)
-  to <- cpl()
+  expect_equal(vec_cast(lgl(NA), cpl()), NA_complex_)
+  expect_equal(vec_cast(int(NA), cpl()), NA_complex_)
 
-  expect_equal(vec_cast(lgl(NA), to), exp)
-  expect_equal(vec_cast(int(NA), to), exp)
-  expect_equal(vec_cast(dbl(NA), to), exp)
+  # TODO: Use our own cast routines here?
+  # `as.complex(NA_real_)` and `Rf_CoerceVector(NA_real_)` coerce to
+  # `complex(real = NA_real_, imaginary = 0)` for some reason, but this may
+  # change in the future https://stat.ethz.ch/pipermail/r-devel/2023-April/082545.html
+  # expect_equal(vec_cast(dbl(NA), cpl()), NA_complex_)
+  expect_type(vec_cast(dbl(NA), cpl()), "complex")
+  expect_identical(is.na(vec_cast(dbl(NA), cpl())), TRUE)
 
   # This used to be allowed
-  expect_error(vec_cast(list(NA), to), class = "vctrs_error_incompatible_type")
+  expect_error(vec_cast(list(NA), cpl()), class = "vctrs_error_incompatible_type")
 })
 
 test_that("Shaped NA casts work as expected", {
   mat <- matrix
-  exp_mat <- mat(cpl(NA))
+  exp_mat <- mat(NA_complex_)
   to_mat <- matrix(cpl())
 
   expect_equal(vec_cast(mat(lgl(NA)), to_mat), exp_mat)
   expect_equal(vec_cast(mat(int(NA)), to_mat), exp_mat)
-  expect_equal(vec_cast(mat(dbl(NA)), to_mat), exp_mat)
+
+  # TODO: Use our own cast routines here?
+  # `as.complex(NA_real_)` and `Rf_CoerceVector(NA_real_)` coerce to
+  # `complex(real = NA_real_, imaginary = 0)` for some reason, but this may
+  # change in the future https://stat.ethz.ch/pipermail/r-devel/2023-April/082545.html
+  # expect_equal(vec_cast(mat(dbl(NA)), to_mat), exp_mat)
+  expect_type(vec_cast(mat(dbl(NA)), to_mat), "complex")
+  expect_identical(is.na(vec_cast(mat(dbl(NA)), to_mat)), matrix(TRUE))
 
   # This used to be allowed
   expect_error(vec_cast(mat(list(NA)), to_mat), class = "vctrs_error_incompatible_type")