Fix CRAN warning due to S3 conditional registration #1832
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC @lionel-
Fixes this NOTE seen in CRAN's checks on R-devel (>=4.3.0 at the time).
This is due to some rewriting of the S3 generics/method check system:
r-devel/r-svn@d34f52a
It only affects methods that we conditionally register which aren't actually registered at vctrs load time. i.e. the dplyr methods are conditionally registered:
I imagine the CRAN check sees that vctrs is "fully loaded" but it didn't officially register S3 methods for these functions that "look" like S3 methods due to the
.
in their names, and that triggers the note.Switching from a
.
to an_
should avoid the NOTE, but also requires manual registration of the method ins3_register()
.