Make vector recycling rules its own FAQ #1885
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1877
Tricky due to r-lib/pkgdown#1876
I was going to update ourvector_recycling_rules
page in vctrs to a true faq page with@name
oftheory-faq-recycling
to match the other faq pages and use@aliases vector_recycling_rules
to retain the old link. But sincevector_recycling_rules
won't get an html page since it is just an alias, that means the places in dplyr where we link to that page will be broken until dplyr rebuilds the site with the new version of vctrs, and I don't want that.So instead I've keptvector_recycling_rules
as the main@name
.To work around the pkgdown issue, I used a manual redirect in
_pkgdown.yml
to ensurevector_recycling_rules.html
always exists