Preserve names when row-binding data frames #924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionel-
force-pushed
the
fix-rbind-names
branch
from
86bf21f
to
066f911
Compare
DavisVaughan
approved these changes
Mar 17, 2020
src/slice-assign.c
Outdated
| proxy_nms = PROTECT(chr_assign(proxy_nms, index, value_nms)); | ||
|
|
||
| proxy = PROTECT(r_maybe_duplicate(proxy)); | ||
| vec_set_names(proxy, proxy_nms); |
There was a problem hiding this comment.
vec_set_names() works like vec_proxy_assign(). It might have to call back to names<- and duplicate the input, so it always returns it's input. So you won't need to duplicate the proxy, but I think you do need to do proxy = PROTECT(vec_set_names(proxy, proxy_nms))
| @@ -517,3 +517,27 @@ test_that("rbind repairs names of data frames (#704)", { | |||
| class = "vctrs_error_names_must_be_unique" | |||
| ) | |||
| }) | |||
|
|
|||
| test_that("rbind supports names and inner names (#689)", { | |||
There was a problem hiding this comment.
This should work with S3 objects like factors / POSIXct that vec_set_names() has to fall back to names<- on, but could you please add a test for that too? It would make me feel a bit better about it
There was a problem hiding this comment.
This would have caught the unassigned return you mentioned above, so that test is definitely needed!
lionel-
force-pushed
the
fix-rbind-names
branch
from
c9519b1
to
9dd2c9e
Compare
lionel-
force-pushed
the
fix-rbind-names
branch
from
9dd2c9e
to
050fb60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branched from #923.
Closes #689.
The internal
vec_assign()function gains anassign_namesparameter. Whentrue, names are assigned row-recursively.vec_c()andvec_rbind()setassign_namestotrueso that they preserve row names and inner names.