Release 2.5.1 #232
Closed
Release 2.5.1 #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes:
── Error ('test-timezone.R:7:5'): with_timezone: changes the time zone ─────────
Error in `format.POSIXlt(as.POSIXlt(x, tz), format, usetz, ...)`: output string exceeded 2048 bytes
Backtrace:
▆
1. ├─testthat::expect_true(...) at test-timezone.R:7:4
2. │ └─testthat::quasi_label(enquo(object), label, arg = "object")
3. │ └─rlang::eval_bare(expr, quo_get_env(quo))
4. ├─... %in% c("PDT", "PST")
5. ├─withr::with_timezone("US/Pacific", format(Sys.time(), "%Z"))
6. │ └─withr::with_envvar(c(TZ = tz), code)
7. │ └─base::force(code)
8. ├─base::format(Sys.time(), "%Z")
9. └─base::format.POSIXct(Sys.time(), "%Z")
10. ├─base::structure(...)
11. └─base::format.POSIXlt(as.POSIXlt(x, tz), format, usetz, ...)
Notes from Kurt:
The errors for r-devel-linux-x86_64-debian-gcc (which will eventually
also show for the other Debian-based checks) are from a recent system
upgrade of the tzdata package which dropped the legacy timezone
symlinks that are not following the current rule of using the
geographical region
(continent or ocean) and city name (the "backward" links from tzdata),
such as
GB -> Europe/London
NZ -> Pacific/Auckland
US/Eastern -> America/New_York
US/Pacific -> America/Los_Angeles
lionel-
force-pushed
the
release-2.5.1
branch
from
0f6c225
to
0752803
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.