Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make xml_serialize()/xml_unserialize() work also for HTML documents #408

Merged
merged 4 commits into from
Nov 10, 2023
Merged

Make xml_serialize()/xml_unserialize() work also for HTML documents #408

merged 4 commits into from
Nov 10, 2023

Conversation

HenrikBengtsson
Copy link
Contributor

Fixes Issue #407

@HenrikBengtsson HenrikBengtsson mentioned this pull request Oct 7, 2023
Closed
hadley
hadley approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@hadley hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Would you mind also add a simple unit test and a bullet to NEWS?

@HenrikBengtsson
Copy link
Contributor Author

Looks good, thanks! Would you mind also add a simple unit test and a bullet to NEWS?

Done.

hadley
hadley reviewed Nov 10, 2023
View reviewed changes
R/xml_serialize.R Outdated Show resolved Hide resolved
@hadley hadley merged commit b9f65ba into r-lib:main Nov 10, 2023
12 checks passed
@hadley
Copy link
Member

hadley commented Nov 10, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hadley hadley hadley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HenrikBengtsson @hadley