Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit test that now fails with shiny 1.6 #62

Merged
merged 3 commits into from
Jan 11, 2021

Conversation

cpsievert
Copy link
Contributor

@cpsievert cpsievert commented Jan 11, 2021

Hi @malcolmbarrett,

We plan on submitting shiny 1.6 to CRAN next week which will cause this unit test to fail. We'd really appreciate it if you could send an update of ymlthis to CRAN with this update before next week so the revdep checks will run smoothly. Let me know if you have any questions or if there's anything else I can do to help out with a ymlthis release.

Thanks,

-Carson

@malcolmbarrett
Copy link
Collaborator

Thanks, Carson! I'll get a patch up soon

@malcolmbarrett malcolmbarrett merged commit 63f447d into r-lib:master Jan 11, 2021
@cpsievert cpsievert deleted the shiny-1.6 branch January 11, 2021 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants