Fix segfault #91
Merged
Fix segfault #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When zip_open_utf8() fails, NULL is returned. That NULL is passed down and eventually ends up in `ftello64(NULL)` causing a NULL pointer dereference, aborting R.
|
Great, thank you very much! |
zeehio
added a commit
to sipss/AlpsNMR
that referenced
this pull request
Nov 2, 2022
After fixing - r-lib/zip#91 - r-lib/zip#92 The zip package works reliably for me again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
zip_open_utf8()fails, NULL is returned.That NULL is passed down and eventually ends up in
ftello64(NULL)causing a NULL pointer dereference, aborting R.With this check, we show an error instead