Fix zipfile delayed evaluation bug #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we use:
zip::zip(
zipfile = file.path(normalizePath("outdir", mustWork=TRUE), "test.zip"),
files = c("a.txt"),
root = "where-a.txt-is-saved"
)
`normalizePath()` will fail because it will be evaluated when
it is first used, and this is in `zip:::zip_internal()` after we
have changed the working directory to `root`.
Here we force the evaluation of zipfile before changing the
directory
zeehio
added a commit
to sipss/AlpsNMR
that referenced
this pull request
Nov 2, 2022
After fixing - r-lib/zip#91 - r-lib/zip#92 The zip package works reliably for me again
|
Great catch! Thanks again! |
|
You're welcome. I love doing this :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one is beautiful
Create a zip file under outdir/test.zip with "a.txt", when "a.txt" is found on a different folder:
If we do it like:
normalizePath()will fail because it will be evaluated when it is first used, and this is inzip:::zip_internal()after we have changed the working directory toroot.Here we force the evaluation of
zipfilebefore changing the directory.I love this delayed evaluation things 😃