Zip permissions #19
Merged
Zip permissions #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More to come...
Might need to create its directories first.
This reverts commit a2343bd.
So we avoid re-allocations.
Cannot print what was already free'd...
gaborcsardi
force-pushed
the
zip-permissions
branch
from
f17af4c
to
f41d322
Compare
Closes #15.
gaborcsardi
force-pushed
the
zip-permissions
branch
from
f41d322
to
81fbf56
Compare
Merged
Codecov Report
@@ Coverage Diff @@
## master #19 +/- ##
===========================================
+ Coverage 37.2% 85.66% +48.46%
===========================================
Files 5 5
Lines 3634 307 -3327
===========================================
- Hits 1352 263 -1089
+ Misses 2282 44 -2238
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is on top of #14.
Closes #15.