Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zip process #22

Merged
merged 3 commits into from
Feb 23, 2019
Merged

Zip process #22

merged 3 commits into from
Feb 23, 2019

Conversation

gaborcsardi
Copy link
Member

Closes #18.

To be refined.

@codecov-io
Copy link

Codecov Report

Merging #22 into master will decrease coverage by 0.48%.
The diff coverage is 84.7%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
- Coverage   85.06%   84.58%   -0.49%     
==========================================
  Files           8       10       +2     
  Lines         375      493     +118     
==========================================
+ Hits          319      417      +98     
- Misses         56       76      +20
Impacted Files Coverage Δ
R/zip.R 100% <ø> (ø) ⬆️
src/rzip.c 93.44% <100%> (+8.3%) ⬆️
src/zip.c 72.61% <64.51%> (-1.84%) ⬇️
R/process.R 89.85% <94.73%> (+5.98%) ⬆️
src/tools/cmdunzip.c 71.42% <0%> (ø)
src/tools/cmdzip.c 78.18% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc8564a...6a55a66. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Feb 23, 2019

Codecov Report

Merging #22 into master will decrease coverage by 0.29%.
The diff coverage is 82.26%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #22     +/-   ##
=========================================
- Coverage   85.06%   84.77%   -0.3%     
=========================================
  Files           8        9      +1     
  Lines         375      486    +111     
=========================================
+ Hits          319      412     +93     
- Misses         56       74     +18
Impacted Files Coverage Δ
R/zip.R 100% <ø> (ø) ⬆️
src/tools/cmdunzip.c 71.42% <ø> (ø)
src/rzip.c 93.44% <100%> (+8.3%) ⬆️
src/zip.c 72.61% <64.51%> (-1.84%) ⬇️
src/tools/cmdzip.c 78.18% <78.18%> (ø)
R/process.R 89.85% <94.87%> (+5.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc8564a...6a55a66. Read the comment docs.

@gaborcsardi gaborcsardi merged commit 4cc5d1a into master Feb 23, 2019
@gaborcsardi gaborcsardi deleted the zip-process branch May 13, 2019 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants