Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several fixes for configure script #86

Merged
merged 3 commits into from
Jan 10, 2024
Merged

Several fixes for configure script #86

merged 3 commits into from
Jan 10, 2024

Conversation

jeroen
Copy link
Contributor

@jeroen jeroen commented Nov 22, 2023

Fixes #87. This fixes a few things:

  • Fix the build for cross-compilation, by using the pkg-config version instead of a test program.
  • Adapt the cut command for when proj version has 2 digits (v10) such that we can't just grab the first character
  • Actually set POSTGIS_PROJ_VERSION from the configure script instead of hardcoding it to 91.

See also in sf: r-spatial/sf#2270

@jeroen jeroen mentioned this pull request Jan 10, 2024
@edzer edzer merged commit 721e351 into r-spatial:master Jan 10, 2024
4 of 5 checks passed
@edzer
Copy link
Member

edzer commented Jan 16, 2024

It seems like packages sf and terra, who build also require GEOS, skip the entire ./configure step, and compile, while lwgeom breaks on a geos test in configure. How can we skip this for wasm / em++?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cross compile broken
2 participants