return sf from edit_map #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t all geojson to sf/sfc
…with assembling the list of sf into a single sf
|
@timelyportfolio I have no problems with these dependencies! I hope to find some time soon to test and get into this more properly |
|
merging in to hopefully get some feedback and testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work-in-progress toward returning
sffromedit_map(). It seems to work, but is fairly ugly. Would be slightly easier with solution for r-spatial/sf#185, butFeatureandFeatureCollectionwill be tricky, so I elected to do withinmapeditfor now.I added dependencies to
dplyrandsf. @tim-salabim, please let me know if there are problems with these newly introduced dependencies.