Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build failure with sf 0.4 and geos <3.5 #260

Closed
rundel opened this issue Mar 21, 2017 · 1 comment
Closed

Build failure with sf 0.4 and geos <3.5 #260

rundel opened this issue Mar 21, 2017 · 1 comment

Comments

@rundel
Copy link
Contributor

rundel commented Mar 21, 2017 •
edited
Loading

Current code uses GEOSContext_setNoticeMessageHandler_r and GEOSContext_setErrorMessageHandler_r in CPL_geos_is_valid. These functions were only added to the geos C api in version 3.5, as such they cause a compiler error for older versions (I believe geos 3.3 and above are supported by sf).

Something like #if GEOS_VERSION_MAJOR >= 3 && GEOS_VERSION_MINOR >= 5 for the offending lines should correct the issue. I would create a pull request but I'm not 100% sure on what the correct behavior should be for geos <3.5.
@edzer
Copy link
Member

edzer commented Mar 22, 2017

Thanks, well spotted!

@edzer edzer closed this as completed in 5e30611 Mar 22, 2017
@edzer edzer mentioned this issue Mar 24, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rundel @edzer