Add a Low-Rank Update type. #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkandpa2
approved these changes
Jan 12, 2023
blester125
force-pushed
the
feat/low-rank-updates
branch
2 times, most recently
from
468a973
to
0f784a6
Compare
This PR adds an implementation of Low Rank Updates. In this setting, the parts of the low rank update are inferred from the difference between the previous and current parameter using SVD. This includes tests that verify that rank inference based on the singular values and also that the application of update results in a numpy allclose result.
blester125
force-pushed
the
feat/low-rank-updates
branch
from
0f784a6
to
9431bd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an implementation of Low Rank Updates. In this setting, the parts of the low rank update are inferred from the difference between the previous and current parameter using SVD.
This includes tests that verify that rank inference based on the singular values and also that the application of update results in a numpy allclose result.
Closes #108