-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preliminary support for geospatial stack #214
Conversation
The build is failing with:
This means that some code was compiled with |
According to https://emscripten.org/docs/porting/setjmp-longjmp.html, So, since we only just recently turned on |
This section is a bit confusing, they also say:
So that's what I've used to be sure. |
Looks like the issue might be in the Emscripten ports version of FreeType. I can see when building in the docker image that
|
The issue with FreeType has been fixed since Emscripten v3.1.35 (emscripten-core/emscripten#19001). So, I spent some time today updating the GHA docker image to Emscripten v3.1.37, so as to match the version currently installed on my own machine. In addition, node v17 or later is required for Wasm exceptions, and the version of node installed by |
So they can be cleaned up or built all at once
Thanks for fixing the build! |
OPTIONAL_WASM_LIBS
. Used inmake clean
andmake all
. All libs should add themselves either to this variable or toDEFALT_WASM_LIBS
.With this I can build the rgdal package. It is not fully functional yet but I'd like to get these changes merged before tackling the rest.