Add help and debug targets, fuzzy assign WEBR_ROOT #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgestagg
reviewed
Apr 23, 2024
georgestagg
reviewed
Apr 23, 2024
georgestagg
reviewed
Apr 23, 2024
georgestagg
reviewed
Apr 23, 2024
georgestagg
reviewed
Apr 23, 2024
georgestagg
reviewed
Apr 23, 2024
georgestagg
reviewed
Apr 23, 2024
georgestagg
reviewed
Apr 23, 2024
georgestagg
approved these changes
Apr 23, 2024
Co-authored-by: George Stagg <georgestagg@gmail.com>
Co-authored-by: George Stagg <georgestagg@gmail.com>
Co-authored-by: George Stagg <georgestagg@gmail.com>
Co-authored-by: George Stagg <georgestagg@gmail.com>
Co-authored-by: George Stagg <georgestagg@gmail.com>
Co-authored-by: George Stagg <georgestagg@gmail.com>
Co-authored-by: George Stagg <georgestagg@gmail.com>
Co-authored-by: George Stagg <georgestagg@gmail.com>
|
@georgestagg no worries. Added the suggestions. This should be ready for a merge when you a moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of digging into the build process, I thought it would be helpful to add to the top-level
Makefile:I've also moved to use a conditional assignment for
WEBR_ROOTso that it is read from the environment variable set up in theDockerfile. (Note: There are a few more changes required for this to be portable, but I wanted to start small.)I'll likely add a similar patch for each subsequent
makes if okay.