build-all breaks in simple/advanced compilation

[totakke]

A combination of sablono and om/build-all is not working in simple/advanced compilation.

Example code:

(def app-state (atom {:list [1 2 3]}))

(defn row [n owner]
  (reify
    om/IRender
    (render [this]
      (html [:li (str n ": " (om/get-shared owner :message))]))))

(defn component1 [data owner]
  (reify
    om/IRender
    (render [this]
      (dom/div nil
        (apply dom/ul nil
          (om/build-all row (:list data)))))))

(defn component2 [data owner]
  (reify
    om/IRender
    (render [this]
      (html [:div
             [:ul (om/build-all row (:list data))]]))))

(om/root component1 ; component2
         app-state
         {:target (. js/document (getElementById "app"))
          :shared {:message "Hello, world!"}})

component1 using om.dom is working. However, component2 using sablono doesn't display "Hello, world" message in the :shared map.

This problem seems to be similar in #119. Putting doall in the front of om/build-all is a workaround. I think sablono should realize components correctly because it is hard to notice this problem. This doesn't occur in :optimizations :none...

[r0man]

@totakke Patch with tests welcome! ;)

[totakke]

@r0man Thank you for comment!

This problem caused by lazy seq and binding was once solved by 426ef6c.

(defn- interpret-seq
  "Interpret the seq `x` as HTML elements."
  [x]
  (into [] (map interpret) x))

However, It recurred by 17ec99d, making interpret-seq lazy. (for performance?)

 (defn- interpret-seq
   "Interpret the seq `x` as HTML elements."
   [x]
-  (into [] (map interpret) x))
+  (map interpret x))

Fixing this by reverting interpret-seq to non-lazy is easy (testing is a little difficult). Is lazy interpret-seq important?

[r0man]

@totakke No, it's not important. Go for it!