Make Patch a method on Differ, so we can specify custom TagName #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @j0s, thanks for the contribution! The changes look good, happy to merge them as is. I need to do a cleanup of some parts of the codebase (when time permits!), so I'll look to move the render methods over to Thanks again! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using custom TagName when generating diff, it's useful to be able to also use custom TagName when calling
Patch(). I'm not sure if it makes sense to haverender*-methods on theDifferinstance instead of on theChangeValue, but at least it accomplishes what I was after. What do you guys think?