Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aarong chapter21 #24

Merged
merged 6 commits into from
Aug 1, 2024
Merged

Aarong chapter21 #24

merged 6 commits into from
Aug 1, 2024

Conversation

spitakiss
Copy link
Contributor

No description provided.

Copy link
Member

@jonthegeek jonthegeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies! This came in just before a vacation, and got buried in my inbox. I think there's an issue with the build; I'll try to fix it if so, but let me know if you're able to fix it! Either way, I'm marking this approved for now in case the build succeeds. Thanks!

@jonthegeek jonthegeek enabled auto-merge (squash) August 1, 2024 10:49
It's helpful to prefix chunks with something identifying the chapter. This chunk label was used in a previous chapter, evidently. This issue will go away when we update the slides to use Quarto, so I'm not making a big deal out of it!
Copy link
Member

@jonthegeek jonthegeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving in case it passes now.

@jonthegeek
Copy link
Member

@spitakiss Whenever you use a package in a book club (or when writing an R package or bookdown book), run usethis::use_package(pkgname), eg usethis::use_package("GGally"). In rare cases (eg tidymodels) you might need to follow the instructions usethis gives in response.

That way the slider-builder knows which packages it needs in order to render the slides.

I think I've fixed all the issues now. Thanks again!

@jonthegeek jonthegeek merged commit 8f2f22e into r4ds:main Aug 1, 2024
1 check passed
@spitakiss
Copy link
Contributor Author

@jonthegeek -- Pardon my delayed response. Thanks for the comments and fixes. I will try to address these potential issues moving forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants