Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup and expose RAPT interface #12

Merged
merged 11 commits into from
Oct 25, 2015
Merged

Cleanup and expose RAPT interface #12

merged 11 commits into from
Oct 25, 2015

Conversation

r9y9
Copy link
Owner

@r9y9 r9y9 commented Oct 24, 2015

This PR is motivated by r9y9/pysptk#30

Summary:

  • Remove if 0 else endif since it is no longer used
  • Remove weird linked list and use array instead
  • Add include guard to SPTK.h and jkGetF0.h
  • A few memory leak fixes of RAPT

TODOs:

  • decide that which I should define rapt function prototype to SPTK.h or jkGetF0.h
  • make rapt into libSPTK
  • pass build on windows (perhaps will fail for now)
  • remove compiler warnings as possible.
  • regression test in pysptk Support RAPT  pysptk#32

I will make a PR to pysptk with a Cython wrapper.

cc: @jfsantos

- Use array instead of linked list
- A few memory leak fixes
- Return return-code
- Remove unnecessary code
@r9y9
Copy link
Owner Author

r9y9 commented Oct 24, 2015

8567873 is the main fixes to RAPT.

r9y9 added a commit to r9y9/pysptk that referenced this pull request Oct 24, 2015
A regression test is also added, that passes in my local environment.

ref r9y9/SPTK#12

should fix #30
@r9y9 r9y9 mentioned this pull request Oct 24, 2015
3 tasks
@r9y9 r9y9 changed the title WIP: Cleanup and expose RAPT interface Cleanup and expose RAPT interface Oct 25, 2015
@r9y9
Copy link
Owner Author

r9y9 commented Oct 25, 2015

I think I'have done.

r9y9 added a commit that referenced this pull request Oct 25, 2015
Cleanup and expose RAPT interface
@r9y9 r9y9 merged commit 902ff37 into master Oct 25, 2015
@r9y9 r9y9 deleted the rapt-cleanup branch October 25, 2015 08:14
r9y9 added a commit that referenced this pull request Oct 27, 2015
@r9y9 r9y9 mentioned this pull request Oct 27, 2015
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant