-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup and expose RAPT interface #12
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use array instead of linked list - A few memory leak fixes - Return return-code - Remove unnecessary code
8567873 is the main fixes to RAPT. |
r9y9
added a commit
to r9y9/pysptk
that referenced
this pull request
Oct 24, 2015
A regression test is also added, that passes in my local environment. ref r9y9/SPTK#12 should fix #30
suppress compiler warnings with gcc (not completely yet with clang)
This suppresses all warnings with clang
r9y9
changed the title
WIP: Cleanup and expose RAPT interface
Cleanup and expose RAPT interface
Oct 25, 2015
I think I'have done. |
r9y9
added a commit
that referenced
this pull request
Oct 25, 2015
Cleanup and expose RAPT interface
r9y9
added a commit
that referenced
this pull request
Oct 27, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is motivated by r9y9/pysptk#30
Summary:
TODOs:
perhaps will fail for now)I will make a PR to pysptk with a Cython wrapper.
cc: @jfsantos