Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sklearn dep warning #100

Merged
merged 1 commit into from
Apr 12, 2020
Merged

Fix sklearn dep warning #100

merged 1 commit into from
Apr 12, 2020

Conversation

r9y9
Copy link
Owner

@r9y9 r9y9 commented Apr 12, 2020

Fixes #99

@r9y9 r9y9 mentioned this pull request Apr 12, 2020
@codecov-io
Copy link

codecov-io commented Apr 12, 2020

Codecov Report

Merging #100 into master will decrease coverage by 0.06%.
The diff coverage is 70.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
- Coverage   80.48%   80.41%   -0.07%     
==========================================
  Files          32       32              
  Lines        1860     1869       +9     
==========================================
+ Hits         1497     1503       +6     
- Misses        363      366       +3     
Impacted Files Coverage Δ
nnmnkwii/preprocessing/generic.py 98.00% <70.00%> (-1.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb7c278...63f351d. Read the comment docs.

@r9y9 r9y9 merged commit 39ac339 into master Apr 12, 2020
@r9y9 r9y9 deleted the fix-sklearn-compat branch April 12, 2020 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Future warning from sklearn
2 participants