Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rogtemplate features #41

Merged
merged 2 commits into from
Oct 30, 2021
Merged

Add rogtemplate features #41

merged 2 commits into from
Oct 30, 2021

Conversation

dieghernan
Copy link
Member

@dieghernan dieghernan commented Oct 28, 2021

Following https://github.com/orgs/rOpenGov/projects/2 and https://github.com/orgs/rOpenGov/teams/core/discussions/2

Also, site should be deployed from gh-pages branch

Additionally, we are moving logos to an standarized format (see https://ropengov.r-universe.dev/ui#packages). Your new logo would be:

@codecov
Copy link

codecov bot commented Oct 28, 2021

Codecov Report

Merging #41 (c4499b0) into master (ef03200) will not change coverage.
The diff coverage is n/a.

❗ Current head c4499b0 differs from pull request most recent head 54bf6c7. Consider uploading reports for the commit 54bf6c7 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master      #41   +/-   ##
=======================================
  Coverage   69.42%   69.42%           
=======================================
  Files           8        8           
  Lines         121      121           
=======================================
  Hits           84       84           
  Misses         37       37           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef03200...54bf6c7. Read the comment docs.

@antagomir
Copy link
Member

antagomir commented Oct 28, 2021

Hi!

Seems good overall - I would leave merging to @muuankarski , though and if @pitkant can also check it would be good.

Re: logos - unified style is nice but I am not sure if we should do this for packages that already have a dedicated custom logo. Another option is to use the template logos only for those packages that do not already have their own custom logo? The current geofi logo seems good to me and it highlights the Finnish landscape which is anyway at the core of the package scope. But we can discuss this, I would leave the final decision to the maintaining author of each package because it is a network of more or less independent contributors, we can encourage good practices, though, and we are not having a similar package review (yet) than rOpenSci, for instance. Perhaps something to consider too.

@pitkant
Copy link
Member

pitkant commented Oct 28, 2021

Perhaps a bit off-topic in regards to the main content of this PR but:

Yes I agree with @antagomir that if packages already have a custom logo it's good if they continue to do so, but if they don't it's good that there's a simple hexagon logo as a placeholder. I wouldn't be too worried about package logos having different visual designs or colour palettes, in my opinion a diverse selection of logos creates a visually more interesting landscape than a set of logos that strictly follow the same design language.

Maybe this is a discussion best had in a more general setting.

@dieghernan
Copy link
Member Author

I am also fine with that. I would put this on hold by now and would remove the logo change of the PR

@dieghernan dieghernan marked this pull request as draft October 28, 2021 11:58
@dieghernan dieghernan marked this pull request as ready for review October 28, 2021 12:03
Copy link
Collaborator

@muuankarski muuankarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, will merge!

@muuankarski muuankarski merged commit e28e69e into master Oct 30, 2021
@dieghernan
Copy link
Member Author

dieghernan commented Oct 30, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants