Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable secure connection #21

Merged
merged 1 commit into from
Feb 19, 2021
Merged

enable secure connection #21

merged 1 commit into from
Feb 19, 2021

Conversation

derrick56007
Copy link
Contributor

#19

allows for connections to secure redis clients

@ra1u
Copy link
Owner

ra1u commented Feb 19, 2021

This looks fine. Thank you for you work.

Can you expose additional function in RedisConnection like Future<Command> connectWithSocket(Socket s) that allows injecting custom socket in similar fashion. This would allow overriding secureSocket options or using stuff like Websockets or even trying rfc1149 at some point in future without modifying current library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants