Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added spice entry for flip-flops #262

Merged
merged 7 commits into from
Apr 21, 2023
Merged

Conversation

Radvall
Copy link
Contributor

@Radvall Radvall commented Apr 20, 2023

I added the spice entry to the existing analog JK flip-flop /w SR, D flip-flop /w SR, T flip-flop flip-flops.
The simulation results are shown below and the circuit is added to the examples/ngspice dirrectory.

flip_flops

From the digital components I added the D-flip-flop. The unused output QB was connected to ground through a 1N capacitor.
And the Set output was connected directly to ground.

@ra3xdh
Copy link
Owner

ra3xdh commented Apr 20, 2023

Thanks for the contribution! I need some time to inspect the added devices. I will give a more detailed feedback soon. Also please consider to upload some example involving digital devices.

@ra3xdh ra3xdh added this to the 1.0.2 milestone Apr 20, 2023
@ra3xdh ra3xdh merged commit 7e2f2ab into ra3xdh:current Apr 21, 2023
@ra3xdh
Copy link
Owner

ra3xdh commented Apr 21, 2023

I have tested new devices and found no visible issues. Merging this. Thanks for the contribution!

This was referenced Apr 21, 2023
@Radvall Radvall deleted the add_flip_flops branch April 21, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants