Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed macOS build and added macOS and MSYS2 actions #3

Merged
merged 3 commits into from
May 7, 2024

Conversation

dsm
Copy link
Contributor

@dsm dsm commented May 6, 2024

Hi, this PR made macos build succesfull.

-fixed VERSION file problem because of macos fs is case sensitive.
-added macos github action.
-some cmake error fixes.

-fixed VERSION file problem because of macos fs is case sensitive.
-added macos github action.
-some cmake error fixes.
@ra3xdh ra3xdh linked an issue May 7, 2024 that may be closed by this pull request
@ra3xdh
Copy link
Owner

ra3xdh commented May 7, 2024

See my line comments on the commits related to windows.yml The -G "MinGW Makefiles" option should help for MSYS2.

@ra3xdh ra3xdh added this to the 1.0.1 milestone May 7, 2024
@dsm
Copy link
Contributor Author

dsm commented May 7, 2024

in local msys2 -G 'Unix Makefiles' work in mingw64 and ucrt64 but i don't know why not working on ci

@dsm
Copy link
Contributor Author

dsm commented May 7, 2024

windows build using msys2 fixed and added basic github action.

@ra3xdh
Copy link
Owner

ra3xdh commented May 7, 2024

Thanks! Please squash 11 commits related to windows.yml using the Git interactive rebase git rebase -i and update your branch using force push. The I will merge this.

@dsm
Copy link
Contributor Author

dsm commented May 7, 2024

i fixed the 11 commits issue, i forgot to create different brach for this :)

@dsm dsm changed the title fixed macos build. fixed macOS build and added macOS and MSYS2 actions May 7, 2024
@ra3xdh ra3xdh merged commit 7494604 into ra3xdh:develop May 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

macos build error
2 participants